Include task args in run_tasks_async independent case#1233
Open
superMDguy wants to merge 1 commit intoPrefectHQ:mainfrom
Open
Include task args in run_tasks_async independent case#1233superMDguy wants to merge 1 commit intoPrefectHQ:mainfrom
superMDguy wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where task arguments were not being passed to individual tasks when running multiple independent tasks concurrently. The change ensures that thread, raise_on_failure, and handlers parameters are properly propagated to each task's run_async method.
- Updated asyncio.gather call to include task execution parameters
- Improved code formatting by splitting the complex gather expression across multiple lines
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+46
to
+48
| task.run_async( | ||
| thread=thread, raise_on_failure=raise_on_failure, handlers=handlers | ||
| ) |
There was a problem hiding this comment.
The task.run_async() method signature appears to be different from the one being called. Based on the context excerpt, task.run_async() doesn't accept thread, raise_on_failure, or handlers parameters, but this code is trying to pass them.
Suggested change
| task.run_async( | |
| thread=thread, raise_on_failure=raise_on_failure, handlers=handlers | |
| ) | |
| task.run_async() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.